json-parser: basic support for ShellCheck's JSON output #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
kdudka
force-pushed
the
shellcheck-json
branch
from
b73278e
to
4e08114
Compare
|
I think this is safe to be merged. We can extend the support for ShellCheck's JSON output in subsequent merge requests. |
jamacku
requested changes
Sep 30, 2022
There was a problem hiding this comment.
@kdudka Thank you. Only one small thing. I think the commit message should say --format=json1 instead of only json as mentioned in:
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Sep 30, 2022
... which is produced by `shellcheck --format=json1 ...` Fixes: csutils#75 Closes: csutils#83
kdudka
force-pushed
the
shellcheck-json
branch
from
4e08114
to
5b7b712
Compare
|
@jamacku Good catch! Fixed. |
lzaoral
requested changes
Sep 30, 2022
... which is produced by `shellcheck --format=json1 ...` Related: csutils#75 Closes: csutils#83
kdudka
force-pushed
the
shellcheck-json
branch
from
5b7b712
to
3ab6fbf
Compare
|
@lzaoral You are right. Fixed. |
lzaoral
approved these changes
Sep 30, 2022
jamacku
approved these changes
Oct 3, 2022
|
@lzaoral Note that using |
|
Sorry, @kdudka. I did not know that and it is a rather stupid behaviour. |
|
My bad. The issue was explicitly linked with the pull request on GitHub. The use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... which is produced by
shellcheck --format=json1 ...